adamovanja commented 2 years ago

This PR edits sensitive Zotero library information to be imported as environment variables instead of as input parameters to the method. This inhibits saving of this information in Q2 provenance.

Testing Set the required environment variables as described in the README.md file and use the scrape-collection method with a Zotero library collection of your choice.

codecov-commenter commented 2 years ago

Codecov Report

Merging #121 (dfe5284) into main (608a895) will increase coverage by 0.01%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #121      +/-   ##
==========================================
+ Coverage   95.26%   95.28%   +0.01%     
==========================================
  Files          15       15              
  Lines        1120     1123       +3     
  Branches      206      206              
==========================================
+ Hits         1067     1070       +3     
  Misses         28       28              
  Partials       25       25

Impacted Files	Coverage Δ
q2_fondue/plugin_setup.py	`100.00% <ø> (ø)`
q2_fondue/scraper.py	`99.20% <100.00%> (+0.01%)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 608a895...dfe5284. Read the comment docs.

adamovanja commented 2 years ago

thanks for the review @misialq. I addressed your comments. Let me know what you think.

bokulich-lab / q2-fondue

FIX: Hiding Zotero user info #121

Codecov Report