search

bokulich-lab / q2-fondue

Functions for reproducibly Obtaining and Normalizing Data re-Used from Elsewhere
BSD 3-Clause "New" or "Revised" License
20 stars 6 forks source link

ENH: Scrape hyphenated ID sequences #124

Closed adamovanja closed 2 years ago

adamovanja commented 2 years ago

This PR introduces scraping of accession ID sequences denoted as SRX1479846–50 or SRX1479846–SRX1479850 and closes #118.

Testing Scrape a collection of your choice with publications having hyphenated ID sequences within, such as:

codecov-commenter commented 2 years ago

Codecov Report

Merging #124 (2493762) into main (cb924d4) will increase coverage by 0.26%. The diff coverage is 96.00%.

@@            Coverage Diff             @@
##             main     #124      +/-   ##
==========================================
+ Coverage   95.28%   95.54%   +0.26%     
==========================================
  Files          15       15              
  Lines        1123     1145      +22     
  Branches      206      209       +3     
==========================================
+ Hits         1070     1094      +24     
+ Misses         28       27       -1     
+ Partials       25       24       -1
Impacted Files Coverage Δ
q2_fondue/scraper.py 98.66% <96.00%> (-0.54%) :arrow_down:
q2_fondue/plugin_setup.py 100.00% <0.00%> (ø)
q2_fondue/metadata.py 100.00% <0.00%> (+2.85%) :arrow_up:
q2_fondue/entrezpy_clients/_pipelines.py 100.00% <0.00%> (+4.54%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update cb924d4...2493762. Read the comment docs.