bokulich-lab / q2-fondue

Functions for reproducibly Obtaining and Normalizing Data re-Used from Elsewhere
BSD 3-Clause "New" or "Revised" License
20 stars 6 forks source link

FIX: Sequences mismatch #149

Closed adamovanja closed 1 year ago

adamovanja commented 1 year ago

closes #148

Testing:

  1. Get a run ID that contains both single and paired reads (e.g. SRR000001, SRR000047, SRR000013).
  2. Fetch sequences with fixed q2-fondue get-sequences.
  3. Compare fetched sequences to sequences uploaded on SRA.
codecov[bot] commented 1 year ago

Codecov Report

Merging #149 (74b682f) into main (ae74514) will increase coverage by 0.00%. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #149   +/-   ##
=======================================
  Coverage   98.61%   98.62%           
=======================================
  Files          29       29           
  Lines        2959     2974   +15     
=======================================
+ Hits         2918     2933   +15     
  Misses         41       41           
Impacted Files Coverage Δ
q2_fondue/sequences.py 98.46% <100.00%> (ø)
q2_fondue/tests/test_sequences.py 98.15% <100.00%> (+0.06%) :arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

adamovanja commented 1 year ago

I agree with you that renaming would be a simpler solution. I have not implemented it this way as I did not dare to adjust the barcode 😅. I will refactor it 👍🏼