bokulich-lab / q2-fondue

Functions for reproducibly Obtaining and Normalizing Data re-Used from Elsewhere

BSD 3-Clause "New" or "Revised" License

20 stars 6 forks source link

Update QIIME 2 versions in README #150

Closed lina-kim closed 1 year ago

lina-kim commented 1 year ago

I was using q2-fondue recently and took the liberty of updating the README:

Updated installation code to latest QIIME 2 version
Required v2022.8 instead of v2021.4. The QIIME 2 package channel only contains q2-fondue starting in 2022.8, and I believe the QIIME 2 environment version should be the same as that of the package channel. (I could be wrong there - though it seems like good practice in any case.)

codecov[bot] commented 1 year ago

Codecov Report

Merging #150 (41f5094) into main (d7973b9) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #150   +/-   ##
=======================================
  Coverage   98.62%   98.62%           
=======================================
  Files          29       29           
  Lines        2974     2974           
=======================================
  Hits         2933     2933           
  Misses         41       41

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

lina-kim commented 1 year ago

thanks @lina-lim for this update ⭐.

As for your 2nd point: Yes, the version of the Q2 environment should match the package channel version. Hence, I suggest we make the following changes to the option 2 installation instructions. Let me know what you think.

Thanks so much for the suggestions @adamovanja! I agree, and incorporated your suggestions in the latest commit.