search

bokulich-lab / q2-types-genomics

QIIME 2 types for genomics plugins.
BSD 3-Clause "New" or "Revised" License
6 stars 11 forks source link

FEAT: Eggnog formats and types #30

Closed Keegan-Evans closed 1 year ago

Keegan-Evans commented 2 years ago

Clearly not done, but @misialq, I wanted you to be able to see where I was getting with these. I tweaked the formats to be more in line with the most recent document, and tweaked/fixed some of the basic tests. Monday I am going to work on validation for NOG and hopefully get rolling on the OG and KEGG stuff.

misialq commented 2 years ago

Hey @Keegan-Evans, I only now realized that you tagged me for review a while ago... Do you want me to go through the code or are you still working on it? (I glanced through it and so far it seems πŸ‘)

codecov[bot] commented 2 years ago

Codecov Report

Merging #30 (b92e17d) into main (2147f8b) will decrease coverage by 0.64%. The diff coverage is 93.81%.

:exclamation: Current head b92e17d differs from pull request most recent head 1d463e8. Consider uploading reports for the commit 1d463e8 to get more accurate results

@@            Coverage Diff             @@
##             main      #30      +/-   ##
==========================================
- Coverage   96.01%   95.36%   -0.65%     
==========================================
  Files          25       28       +3     
  Lines         752     1035     +283     
==========================================
+ Hits          722      987     +265     
- Misses         30       48      +18
Impacted Files Coverage Ξ”
q2_types_genomics/genome_data/tests/test_format.py 98.43% <ΓΈ> (ΓΈ)
q2_types_genomics/feature_data/_transformer.py 91.02% <66.66%> (-8.98%) :arrow_down:
q2_types_genomics/feature_data/_format.py 85.24% <84.21%> (-14.76%) :arrow_down:
q2_types_genomics/feature_data/_util.py 90.47% <90.47%> (ΓΈ)
q2_types_genomics/__init__.py 100.00% <100.00%> (ΓΈ)
q2_types_genomics/feature_data/__init__.py 100.00% <100.00%> (ΓΈ)
q2_types_genomics/feature_data/_type.py 100.00% <100.00%> (ΓΈ)
q2_types_genomics/feature_data/_validator.py 100.00% <100.00%> (ΓΈ)
...2_types_genomics/feature_data/tests/test_format.py 98.21% <100.00%> (+4.88%) :arrow_up:
...s_genomics/feature_data/tests/test_transformers.py 98.68% <100.00%> (+0.46%) :arrow_up:
... and 2 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more