search

bokulich-lab / q2-types-genomics

QIIME 2 types for genomics plugins.
BSD 3-Clause "New" or "Revised" License
6 stars 11 forks source link

rename the taxonomy id column in kraken2 report to taxon_id #55

Closed colinvwood closed 1 year ago

colinvwood commented 1 year ago

because kraken2 databases can be trained with taxonomies other than ncbi's

colinvwood commented 1 year ago

after further discussion with @gregcaporaso, taxon_id was decided to be more appropriate than feature_id because the rows of kraken2 output do not correspond to features for MAGs

codecov[bot] commented 1 year ago

Codecov Report

Merging #55 (346e401) into main (cb0aefc) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #55   +/-   ##
=======================================
  Coverage   96.28%   96.28%           
=======================================
  Files          42       42           
  Lines        1293     1293           
=======================================
  Hits         1245     1245           
  Misses         48       48
Files Coverage Δ
q2_types_genomics/kraken2/_format.py 91.13% <ø> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more