bokulich-lab / q2-types-genomics

QIIME 2 types for genomics plugins.
BSD 3-Clause "New" or "Revised" License
6 stars 11 forks source link

add sample dict mapping of sample id to filepath for contig dir format #57

Closed colinvwood closed 1 year ago

colinvwood commented 1 year ago

partially addresses #56

codecov[bot] commented 1 year ago

Codecov Report

Merging #57 (950b034) into main (769db1a) will decrease coverage by 0.08%. Report is 2 commits behind head on main. The diff coverage is 90.00%.

@@            Coverage Diff             @@
##             main      #57      +/-   ##
==========================================
- Coverage   96.28%   96.21%   -0.08%     
==========================================
  Files          42       42              
  Lines        1293     1321      +28     
==========================================
+ Hits         1245     1271      +26     
- Misses         48       50       +2     
Files Coverage Δ
...ypes_genomics/per_sample_data/tests/test_format.py 91.91% <100.00%> (+1.01%) :arrow_up:
q2_types_genomics/feature_data/_format.py 87.50% <80.00%> (-4.17%) :arrow_down:
q2_types_genomics/per_sample_data/_format.py 90.21% <85.71%> (+0.34%) :arrow_up:

:mega: Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

misialq commented 1 year ago

Hey @colinvwood, could you please rebase this on top of main to run it against the new CI? Thanks! 🙏