bokuweb / docx-rs

:memo: A .docx file writer with Rust/WebAssembly.
https://bokuweb.github.io/docx-rs/
MIT License
341 stars 59 forks source link

fix widow_control xml, add character_spacing_control #629

Closed Griklit closed 1 year ago

Griklit commented 1 year ago

docx-rs: <w:widowControl/>

MS Office Word: <w:widowControl w:val="0"/>

WordProcessing Docs: <w:widowControl w:val="off" />

???

Reference

[BUG] issue widow_control XML structure error

bokuweb commented 1 year ago

@GoWon7 Thanks. Could you please update snapshot?

https://github.com/bokuweb/docx-rs/blob/main/CONTRIBUTING.md#pull-request-process

cd docx-wasm & yarn test -- --updateSnapshot
Griklit commented 1 year ago

谢谢。你能更新快照吗?

https://github.com/bokuweb/docx-rs/blob/main/CONTRIBUTING.md#pull-request-process

cd docx-wasm & yarn test -- --updateSnapshot

sorry. I haven't used yarn. I'll try.

Griklit commented 1 year ago

@bokuweb I think, I finally deployed the environment and passed the test and update snapshot.

bokuweb commented 1 year ago

@Griklit Sorry for late. LGTM

cloud you please update snapshot again 🙇

Griklit commented 1 year ago

@Griklit Sorry for late. LGTM

cloud you please update snapshot again 🙇

E, okey, the conflict seems to be a little complicated to deal with.