search

bokuweb / docx-rs

:memo: A .docx file writer with Rust/WebAssembly.
https://bokuweb.github.io/docx-rs/
MIT License
342 stars 60 forks source link

ecma-376-fix #735

Closed ImplFerris closed 1 month ago

ImplFerris commented 3 months ago

What does this change?

Updated Paragraph property, run property, table(row,cell) property elements' order as per the ECMA-376 spec.

References

ECMA-376: https://ecma-international.org/publications-and-standards/standards/ecma-376/

Related Issue: https://github.com/bokuweb/docx-rs/issues/724

Screenshots

If applicable, add screenshots to help explain your changes. Validated the ooxml doc ooxml-fix

What can I check for bug fixes?

You can use the vscode ooxml validator (https://marketplace.visualstudio.com/items?itemName=mikeebowen.ooxml-validator-vscode) to check if generated docx is valid as per ooxml.

bokuweb commented 3 months ago

@ImplFerris Thanks for your great work!!!!!!!!!!!!

bokuweb commented 2 months ago

Thank you. Since the impact is significant, please give me some time.

bokuweb commented 2 months ago

@ImplFerris

LGTM!! for now I'll merge into 0.5.0-dev branch to evaluation. sorry, could you resolve conflict 🙏

bokuweb commented 2 months ago

[question] is there way to validate ecma spec in ci?

ImplFerris commented 2 months ago

[question] is there way to validate ecma spec in ci?

I'll need to look into, I'll get back to you on this