bokuweb / re-bulma

[Deprecated] 💎Bulma components for React
http://bokuweb.github.io/re-bulma/
MIT License
364 stars 66 forks source link

<span></span> wrapping button content #64

Closed MartinWillitts closed 7 years ago

MartinWillitts commented 7 years ago

I found a problem with centre aligning text in a button on Safari. It's to do with the width being set and Safari (and iPhone) then ignoring the text-align attribute. Putting around the button content resolved the problem. (One shortcoming of the solution is that onClick handlers on the button may need to check if the target is the span or the button if they need to deal with the target itself.)

bokuweb commented 7 years ago

LGTM 👍