search

bokuweb / re-bulma

[Deprecated] 💎Bulma components for React
http://bokuweb.github.io/re-bulma/
MIT License
364 stars 66 forks source link

Incorrect use of the `module` field for ES2015 module-support #72

Closed eltonjuan closed 7 years ago

eltonjuan commented 7 years ago

Added with this commit aee8cbc9ec1a0bf8d64121750fc2f0cc0e4b97a2 , it seems that re-bulma is incorrectly using the module field in package.json. Using webpack2, re-bulma is failing to build because the module field is pointing to src/index.js which is a file that requires transpilation.

Correct me if I'm wrong, but all of my research on the topic leads me to believe that the module field should still be built & transpiled, leaving only the ES2015 module syntax in tact (i.e. import and export are okay, but as a consumer we still need you to transpile / build your code). If you look at redux, they have a build step that transpiles their code using babel, but leaves the es6 module syntax in place.

eltonjuan commented 7 years ago

@capaj I noticed you committed the original change, am I correct in my assessment?

capaj commented 7 years ago

Yes it should be built to be es2015 compatible.re-bulma also uses jsx and stage-1 so we're definitely missing a build step there. Will try to open a fixing PR.

capaj commented 7 years ago

@eltonjuan fixing PR here: #74

eltonjuan commented 7 years ago

Thanks for the quick turnaround! 👍