search

bokuweb / react-rnd

🖱 A resizable and draggable component for React.
https://bokuweb.github.io/react-rnd/stories
MIT License
3.94k stars 324 forks source link

Npm registry version differs from github release #690

Open NeroVanbiervliet opened 4 years ago

NeroVanbiervliet commented 4 years ago

Overview of the problem

I'm using react-rnd version [10.1.9] (see npm)

My browser is: Chrome (electron)

Steps to Reproduce

  1. yarn add react-rnd
  2. Version in package.json will be 10.1.9

Expected behavior

Version to be consistent with github releases (10.1.8 or 9.1.1)

NeroVanbiervliet commented 4 years ago

As a side node, version 10.1.9 made our application crash upon building.

bokuweb commented 4 years ago

As a side node, version 10.1.9 made our application crash upon building.

@NeroVanbiervliet Thanks for your report :) Could you please provide reproduced project in codesandbox? It seems that 10.1.9 works following sample.

https://codesandbox.io/s/y3997qply9

NeroVanbiervliet commented 4 years ago

I cannot reproduce it in codesandbox. In our project, it works fine in development using webpack-dev-server. But as soon as I bundle our code for production, it crashes. We get the following error

super expression must either be null or a function, not undefined react build

Switching to 10.1.8 solved the issue. I can provide you with more info concerning our environment/project setup if you wish!

bokuweb commented 4 years ago

@NeroVanbiervliet I guess react-draggable cause this error. https://github.com/STRML/react-draggable/issues/476

I'll downgrade react-draggable for now.

bokuweb commented 4 years ago

Downgrade react-draggable for now

bokuweb commented 4 years ago

https://github.com/bokuweb/react-rnd/releases/tag/v10.1.10

NeroVanbiervliet commented 4 years ago

Confirmed fixed :) Thanks a lot!

STRML commented 4 years ago

Hi - if any of you can recreate this error in React-Draggable 4.3.1 we'd be very happy to find out how you did it. There is no appreciable difference we can find in the bundling between 4.2.0 and 4.3.1, but many users are reporting this with no reproduction.

If someone could post a reproduction, we can get it fixed quickly.

bokuweb commented 4 years ago

@NeroVanbiervliet @MBaert Do you have any information about this?

NeroVanbiervliet commented 4 years ago

I created a fork of an electron boilerplate to demonstrate the issue here. In my only commit I added react-rnd @ 10.1.9 and imported it in the index.

Reproduction steps

  1. yarn install
  2. yarn package
  3. run executable in builds/
  4. check dev console to see the error "Uncaught TypeError: Super expression must either be null or a function"

As stated above the error only occurs after bundling, not in dev mode.

STRML commented 4 years ago

Thank you very much @NeroVanbiervliet. Because of your reproduction I was able to verify that react-draggable@4.4.0 fixes the original issue, and discovered another bundling issue that is fixed in 4.4.1.

@bokuweb thanks for your patience with me, I had a hare-brained idea to modernize the builds I was shipping to support umd, cjs, and modules - an exercise in futility to handle well, with the costs far outweighing the benefits. Most of that work is deleted in 4.4.1, and the only exposed build is ES5-compliant, unminified, CJS source.