Numerous improvements on logging and metrics - Githubissues

bolcom / libunftp

Extensible, async, cloud orientated FTP(S) server library and the core of unFTP: https://github.com/bolcom/unFTP. Follow up and talk to us on https://t.me/unftp

Apache License 2.0

182 stars 33 forks source link

Numerous improvements on logging and metrics #461

Closed robklg closed 1 year ago

robklg commented 1 year ago

Fixes #420 (omit multi line output in the logs) Fixes part one of #81 (although was already handled mostly by Werner)

And lots of other things I came across:

Logging:

Improved mappings from storage errors to FTP errors
Moved many log messages from INFO to DEBUG level
Introduced more user friendly log messages at INFO level
Improved the log messages for all commands, making sure the log entries are clear and 'actionable'
Introduced nice additional information on transfers (duration, size and transfer speed)
Added some error logs when there were none

Metrics:

Added a specific counter metric for data transfer commands, with a verdict on whether it's a server or client error
Added in-flight count on transferred bytes (also labeled by command) so that we can calculate average transfer speed

Some bug fixes:

LIST and NLST weren't returning replies correctly
RETR was sending no Reply on the Control channel when there was no Data connection, causing the client to hang
Bug with REST (restart) command not working correctly

robklg commented 1 year ago

I will break this up into multiple commits and do a thorough check myself, so no need to review yet.