Fix a merge error in unftp-sbe-fs functional tests

bolcom / libunftp

Extensible, async, cloud orientated FTP(S) server library and the core of unFTP: https://github.com/bolcom/unFTP. Follow up and talk to us on https://t.me/unftp

Apache License 2.0

182 stars 33 forks source link

Fix a merge error in unftp-sbe-fs functional tests #488

Closed asomers closed 1 year ago

asomers commented 1 year ago

PRs #474 and #473 had another merge conflict that caused runtime test failures.

hannesdejager commented 1 year ago

Is this based on the latest master? I didn't see any test failures with the last MR.

asomers commented 1 year ago

Yes. But the test failures aren't deterministic. They happen when running the tests on a multicore system or with --test-threads > 1. If the rmd test runs at the same time as another test, it is possible that they will both try to use port 1243 at the same time, resulting in a ConnectionError for one or the other.