search

bolcom / libunftp

Extensible, async, cloud orientated FTP(S) server library and the core of unFTP: https://github.com/bolcom/unFTP. Follow up and talk to us on https://t.me/unftp
Apache License 2.0
188 stars 35 forks source link

unftp-sbe-fs: don't panic during Filesystem::new #521

Open asomers opened 2 months ago

asomers commented 2 months ago

Filesystem::new will now return an error if it can't open the root directory. However, ServerExt::with_fs will still panic because the ServerBuilder is required to be infalliable.

hannesdejager commented 1 day ago

@asomers can you explain why you would need this change?

asomers commented 1 day ago

@asomers can you explain why you would need this change?

Because this is an error that can result from misconfiguration rather than a programming bug, and a properly formatted error message is more readable than a stack trace.