search

bold-commerce / go-shopify

Go client for the Shopify API
MIT License
318 stars 252 forks source link

Remove deprecated fields #158

Closed b1gb4by closed 1 year ago

b1gb4by commented 3 years ago

The "gateway" field written in "order.json" is now deprecated and can be removed.

If you want to support older versions, you can reject this request.

See Shopify API documentation: https://shopify.dev/docs/admin-api/rest/reference/orders/order

codecov[bot] commented 3 years ago

Codecov Report

Merging #158 (39f515f) into master (f29f869) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #158   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           37        37           
  Lines         1255      1255           
=========================================
  Hits          1255      1255
Impacted Files Coverage Δ
order.go 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f29f869...39f515f. Read the comment docs.

oliver006 commented 1 year ago

Thanks for the PR!

Let's keep the field, the documentation still shows it in the API response so some people might still rely on it.