bold-commerce / go-shopify

Go client for the Shopify API
MIT License
328 stars 255 forks source link

InventoryLevel #166

Closed lukecyca closed 1 year ago

lukecyca commented 3 years ago

This is a re-do of PR #159 which I messed up after getting @ttyfky's review.

This addresses the outstanding issue that prevented PR #102 from being merged.

This also takes the place of PR #133 which can be closed once this is merged.

codecov[bot] commented 3 years ago

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.01 :tada:

Comparison is base (1a041be) 99.31% compared to head (b3031a0) 99.33%.

:exclamation: Current head b3031a0 differs from pull request most recent head 27ed72e. Consider uploading reports for the commit 27ed72e to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #166 +/- ## ========================================== + Coverage 99.31% 99.33% +0.01% ========================================== Files 39 41 +2 Lines 1601 1647 +46 ========================================== + Hits 1590 1636 +46 Misses 10 10 Partials 1 1 ``` | [Impacted Files](https://codecov.io/gh/bold-commerce/go-shopify/pull/166?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Bold+Commerce) | Coverage Δ | | |---|---|---| | [access\_scopes.go](https://codecov.io/gh/bold-commerce/go-shopify/pull/166?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Bold+Commerce#diff-YWNjZXNzX3Njb3Blcy5nbw==) | `100.00% <ø> (ø)` | | | [asset.go](https://codecov.io/gh/bold-commerce/go-shopify/pull/166?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Bold+Commerce#diff-YXNzZXQuZ28=) | `100.00% <ø> (ø)` | | | [product\_listing.go](https://codecov.io/gh/bold-commerce/go-shopify/pull/166?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Bold+Commerce#diff-cHJvZHVjdF9saXN0aW5nLmdv) | `100.00% <ø> (ø)` | | | [collection.go](https://codecov.io/gh/bold-commerce/go-shopify/pull/166?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Bold+Commerce#diff-Y29sbGVjdGlvbi5nbw==) | `100.00% <100.00%> (ø)` | | | [fulfillment\_service.go](https://codecov.io/gh/bold-commerce/go-shopify/pull/166?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Bold+Commerce#diff-ZnVsZmlsbG1lbnRfc2VydmljZS5nbw==) | `100.00% <100.00%> (ø)` | | | [goshopify.go](https://codecov.io/gh/bold-commerce/go-shopify/pull/166?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Bold+Commerce#diff-Z29zaG9waWZ5Lmdv) | `96.55% <100.00%> (+0.02%)` | :arrow_up: | | [inventory\_level.go](https://codecov.io/gh/bold-commerce/go-shopify/pull/166?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Bold+Commerce#diff-aW52ZW50b3J5X2xldmVsLmdv) | `100.00% <100.00%> (ø)` | | | [price\_rule.go](https://codecov.io/gh/bold-commerce/go-shopify/pull/166?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Bold+Commerce#diff-cHJpY2VfcnVsZS5nbw==) | `100.00% <100.00%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Bold+Commerce). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Bold+Commerce)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

evermile-mitko commented 2 years ago

Hey @ttyfky , is there any chance that you can take a look at this PR? I came to the PR with the need to use the InventoryLevel functionality from the client and it will be a shame to fork the repo only to have these changes integrated.

And @lukecyca - thanks for you effort on this!

oliver006 commented 1 year ago

Thanks for your PR! I recently joined as a maintainer and will start with reviewing and merging PRs in this repo as soon as possible. There's a bit of a backlog and I will hopefully get to this PR soon to get it merged.

In the meantime, can you rebase the PR please? Thanks!

oliver006 commented 1 year ago

@lukecyca - quick bump to see if you want to finish this PR. would love to get this merged but totally understand if you don't want to take this up again almost 2 years later.