Codecov Report

Merging #176 (02fa432) into master (f29f869) will not change coverage. The diff coverage is n/a.

@@            Coverage Diff             @@
##            master      #176    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files           37        37            
  Lines         1255      1531   +276     
==========================================
+ Hits          1255      1531   +276

Impacted Files	Coverage Δ
metafield.go	`100.00% <ø> (ø)`
blog.go	`100.00% <0.00%> (ø)`
page.go	`100.00% <0.00%> (ø)`
shop.go	`100.00% <0.00%> (ø)`
util.go	`100.00% <0.00%> (ø)`
asset.go	`100.00% <0.00%> (ø)`
image.go	`100.00% <0.00%> (ø)`
oauth.go	`100.00% <0.00%> (ø)`
order.go	`100.00% <0.00%> (ø)`
theme.go	`100.00% <0.00%> (ø)`
... and 28 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f29f869...02fa432. Read the comment docs.

BoldBrandonM commented 2 years ago

Does this MR set us up for a newer version of Shopify, or will there be a subsequent MR to handle that? Would be nice to include some mention in readme or wherever is appropriate, stating what version we should support up to. Left a couple other comments, but otherwise LGTM

This MR will only be handling the metafields change, there are many others and go-shopify seems to support them ad-hoc (ie. multiple API versions are supported at once, and to varying degrees of support). We can't really say that we support up to a specific version in here given that being the case. Thanks for the thorough review!

bold-commerce / go-shopify

Add Metafield Type field (#175) #176

Codecov Report