search

bold-commerce / go-shopify

Go client for the Shopify API
MIT License
318 stars 252 forks source link

Add send receipt and send fulfillment receipt flags to Order model #189

Closed ggrant005 closed 1 year ago

ggrant005 commented 2 years ago

These two flags are mentioned in the REST API Docs, but were left out of the go API

codecov[bot] commented 2 years ago

Codecov Report

Patch and project coverage have no change.

Comparison is base (49ba021) 100.00% compared to head (f774a1f) 100.00%.

:exclamation: Current head f774a1f differs from pull request most recent head 0bd24f6. Consider uploading reports for the commit 0bd24f6 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #189 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 38 38 Lines 1537 1537 ========================================= Hits 1537 1537 ``` | [Impacted Files](https://codecov.io/gh/bold-commerce/go-shopify/pull/189?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Bold+Commerce) | Coverage Δ | | |---|---|---| | [order.go](https://codecov.io/gh/bold-commerce/go-shopify/pull/189?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Bold+Commerce#diff-b3JkZXIuZ28=) | `100.00% <ø> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Bold+Commerce). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Bold+Commerce)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

oliver006 commented 1 year ago

Thanks for your PR! I recently joined as a maintainer and so PRs should move a bit quicker again.

Can you please rebase your PR so I can go ahead and merge it? Thanks!

ggrant005 commented 1 year ago

Thanks for your PR! I recently joined as a maintainer and so PRs should move a bit quicker again.

Can you please rebase your PR so I can go ahead and merge it? Thanks!

Done. Thanks!

oliver006 commented 1 year ago

Can you resolve the merge conflicts please? Thanks!

oliver006 commented 1 year ago

Fixed in #201