bold-commerce / go-shopify

Go client for the Shopify API
MIT License
318 stars 252 forks source link

fix: Omit empty API version for webhook #205

Closed sradevski closed 1 year ago

sradevski commented 1 year ago

Currently the Create method doesn't work at all, since we always send an empty "api_version" to Shopify. The api_version is read-only, and as such, Shopify doesn't allow you to pass it as an argument at all, therefore the request fails on validation.

codecov[bot] commented 1 year ago

Codecov Report

Patch and project coverage have no change.

Comparison is base (1be1524) 100.00% compared to head (d560ea4) 100.00%.

:exclamation: Current head d560ea4 differs from pull request most recent head 8baeda4. Consider uploading reports for the commit 8baeda4 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #205 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 42 42 Lines 1673 1673 ========================================= Hits 1673 1673 ``` | [Impacted Files](https://codecov.io/gh/bold-commerce/go-shopify/pull/205?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Bold+Commerce) | Coverage Δ | | |---|---|---| | [webhook.go](https://codecov.io/gh/bold-commerce/go-shopify/pull/205?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Bold+Commerce#diff-d2ViaG9vay5nbw==) | `100.00% <ø> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Bold+Commerce). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Bold+Commerce)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.