bold-commerce / go-shopify

Go client for the Shopify API
MIT License
330 stars 256 forks source link

feat: add support FulfillmentOrder #216

Closed krisatverbidio closed 1 year ago

krisatverbidio commented 1 year ago

Add methods and some tests for FulfillmentOrder (fixes #197)

Most tests are implemented, but the final few are stubbed out empty.

krisatverbidio commented 1 year ago

@oliver006 , sorry I failed to squash these commits before the PR. my bad.

oliver006 commented 1 year ago

Thanks for the PR - I hope to get to this in the next few days.

And no worries about not squashing the commits, we can do that later.

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (1cd307e) 100.00% compared to head (79c3cd6) 100.00%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #216 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 45 46 +1 Lines 1995 2088 +93 ========================================= + Hits 1995 2088 +93 ``` | [Files Changed](https://app.codecov.io/gh/bold-commerce/go-shopify/pull/216?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Bold+Commerce) | Coverage Δ | | |---|---|---| | [fulfillment\_order.go](https://app.codecov.io/gh/bold-commerce/go-shopify/pull/216?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Bold+Commerce#diff-ZnVsZmlsbG1lbnRfb3JkZXIuZ28=) | `100.00% <100.00%> (ø)` | | | [goshopify.go](https://app.codecov.io/gh/bold-commerce/go-shopify/pull/216?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Bold+Commerce#diff-Z29zaG9waWZ5Lmdv) | `100.00% <100.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Viktoop commented 1 year ago

hey all, any updates on this topic ?