search

bold-commerce / go-shopify

Go client for the Shopify API
MIT License
330 stars 256 forks source link

Remove ValueType field from Metafields since it was deprecated. #220

Closed c9845 closed 1 year ago

c9845 commented 1 year ago

The ValueType field of a Metafield was deprecated some time long ago (2021?). As of API version 2023-07 it is no longer supported. The Type field should be used instead. This removes the ValueType field from the Metafield type.

c9845 commented 1 year ago

See list of fields supported for Metafields at the Shopify API docs: https://shopify.dev/docs/api/admin-rest/2022-10/resources/metafield

codecov[bot] commented 1 year ago

Codecov Report

Patch and project coverage have no change.

Comparison is base (933070b) 100.00% compared to head (ea10b2f) 100.00%.

:exclamation: Current head ea10b2f differs from pull request most recent head 3b878db. Consider uploading reports for the commit 3b878db to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #220 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 44 44 Lines 1715 1715 ========================================= Hits 1715 1715 ``` | [Impacted Files](https://app.codecov.io/gh/bold-commerce/go-shopify/pull/220?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Bold+Commerce) | Coverage Δ | | |---|---|---| | [metafield.go](https://app.codecov.io/gh/bold-commerce/go-shopify/pull/220?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Bold+Commerce#diff-bWV0YWZpZWxkLmdv) | `100.00% <ø> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.