search

bold-commerce / go-shopify

Go client for the Shopify API
MIT License
330 stars 256 forks source link

Backwards incompatible changes for 4.0 #258

Closed oliver006 closed 10 months ago

oliver006 commented 10 months ago

Couple of breaking changes that will go into 4.0

In particular, this one addresses PRs:

codecov[bot] commented 10 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (ff955b4) 100.00% compared to head (2c9c92e) 100.00%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #258 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 51 51 Lines 2198 2207 +9 ========================================= + Hits 2198 2207 +9 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

oliver006 commented 10 months ago

Looks like some changes to customer and order APIs were pulled in, are they related to the breaking changes?

I did some merging - rebasing after the recent PRs #260 and #261 and #259 which modified order.go and customer.go but I just looked at the diff here and it seems fine. Anything sticking out that shouldn't be there?

BoldBrandonM commented 10 months ago

Looks like some changes to customer and order APIs were pulled in, are they related to the breaking changes?

I did some merging - rebasing after the recent PRs #260 and #261 and #259 which modified order.go and customer.go but I just looked at the diff here and it seems fine. Anything sticking out that shouldn't be there?

Oh I was just looking at the diff between the pushes, but if that's just from the master branch then no worries.