bold-commerce / go-shopify

Go client for the Shopify API
MIT License
318 stars 251 forks source link

RecurringApplicationCharge has no field 'currency' #262

Closed OliverAAAAA closed 6 months ago

OliverAAAAA commented 7 months ago

Official documents has field 'currency' = "USD" behind

{ "activated_on": null, "billing_on": null, "cancelled_on": null, "capped_amount": "100", "confirmation_url": "https://jsmith.myshopify.com/admin/charges/confirm_recurring_application_charge?id=654381177&signature=BAhpBHkQASc%3D--374c02da2ea0371b23f40781b8a6d5f4a520e77b", "created_at": "2013-06-27T08:48:27-04:00", "id": 675931192, "name": "Super Duper Expensive action", "price": "100.00", "return_url": "http://super-duper.shopifyapps.com", "status": "accepted", "terms": "$1 for 1000 emails", "test": null, "trial_days": 0, "trial_ends_on": null, "updated_at": "2013-06-27T08:48:27-04:00", "currency": "USD" }

oliver006 commented 6 months ago

Good catch, that's missing. Can you open a PR that adds it? Thanks!

OliverAAAAA commented 6 months ago

yeah, i have opened a PR , please review it !

oliver006 commented 6 months ago

Done - thanks!