search

boldare / salesforce-client

MIT License
30 stars 13 forks source link

Serialization config #48

Open krzysztof-ciszewski opened 7 years ago

krzysztof-ciszewski commented 7 years ago

Consider moving serialization configurations into it's own file, in my opinion it would make the code and the configuration itself more readable.

adrianwaler commented 7 years ago

I'm not sure about that. This is just library and we shouldn't restrict configuration, for example you can use https://github.com/schmittjoh/JMSSerializerBundle.

It's my opinion, what do you think @Kryniol ?

Kryniol commented 7 years ago

@krzysztofc-xsolve Do you mean to switch to yaml or xml instead of using annotations?

krzysztof-ciszewski commented 7 years ago

@Kryniol yes, sorry, I wasn't clear enough. @adrianwaler that's exactly why you should move serialization outside the class itself.