search

boldenamsterdam / htmlcache

Cache pages to HTML and boost website performance on Craft CMS 3
MIT License
31 stars 21 forks source link

blank page on first load due to previous patch #6

Closed bragle closed 5 years ago

bragle commented 5 years ago

Turns out that my previous patch didn't work quite as intended. Now, on first load, a blank page is shown. Echoing $content instead of setting \Craft::$app->response->data to $content works fine, but I see no reason not to just serve the original output buffer.

bragle commented 5 years ago

I added an option to remove whitespace from the cached file. You can add that if you want to :)

stursby commented 5 years ago

@bragle @boldenamsterdam I too am getting a white/blank page on first load. Does this PR solve this?

boldenamsterdam commented 5 years ago

@stursby I cannot replicate the issue with my setup. @bragle Does this pull fix the white page issue? If yes then I will merge and release it.

bragle commented 5 years ago

@boldenamsterdam It does, but it also adds an option for whitespace removal when caching. If you want that, you can merge, but if you only want the white page fix, I can remove the added functionality.