bolderbrush10 / SearchlightAssault

A lua mod adding searchlights to the game factorio
MIT License
0 stars 0 forks source link

Settings name gets overwritten #5

Closed StephenBarnes closed 3 months ago

StephenBarnes commented 3 months ago

Hi, this is a minor bug in your sl-defines.lua:

-- Mod settings keys
-- d.lightRadiusSetting = defined above
d.ignoreEntriesList = "searchlight-assault-setting-ignore-entries-list"
d.uninstallMod      = "searchlight-assault-uninstall"
d.overrideAmmoRange = "searchlight-assault-override-ammo-range"
d.enableLightAnimation = "searchlight-assault-enable-light-animation"
d.enableBoostGlow   = "searchlight-assault-enable-boost-glow"
d.alarmColorDefault = "searchlight-assault-alarm-color"
d.warnColorDefault  = "searchlight-assault-warn-color"
d.safeColorDefault  = "searchlight-assault-safe-color"

-- Default color settings
d.warnColorDefault  = "250,190,0,230"
d.alarmColorDefault = "230,25,25,230"
d.safeColorDefault  = "20,230,20,230"

You are setting d.alarmColorDefault twice. So instead of creating a setting with the name "searchlight-assault-alarm-color" and default value "230,25,25,230" you are creating a setting with name "230,25,25,230" and default value "230,25,25,230". But because the replacement is consistent everywhere the setting is used, it doesn't cause any user-facing errors.

Discovered this when I was working on a modpack that includes your mod and changes your mod's settings:

-- Set warning color and safe color to 230/230/230/230
-- Set alarm color to 255/255/255/230
--Settings.setDefault("searchlight-assault-safe-color", "string", "230,230,230,230")
--Settings.setDefault("searchlight-assault-warn-color", "string", "230,230,230,230")
--Settings.setDefault("searchlight-assault-alarm-color", "string", "255,255,255,230")
-- Lines above do not work, instead I have to do:
Settings.setDefault("250,190,0,230", "string", "230,230,230,230")
Settings.setDefault("230,25,25,230", "string", "230,230,230,230")
Settings.setDefault("20,230,20,230", "string", "255,255,255,230")
bolderbrush10 commented 3 months ago

Thanks for the report! This has just been fixed in Release v2.2.17