bolduc / VirSorter

KBase integration of VirSorter
MIT License
1 stars 3 forks source link

Fix input to kbaseBinnedContigs output widget #4

Closed MrCreosote closed 3 years ago

MrCreosote commented 3 years ago

VirSorter provides the binned_contig_obj_ref field to the kbaseBinnedContigs output widget, but that widget expects anobjRef field: https://github.com/kbase/narrative/blob/develop/kbase-extension/static/kbase/js/widgets/function_output/kbaseBinnedContigs.js#L33-L47

This PR adds the expected field.

Unfortunately I can't test this without deploying it, and I can't deploy it, so I can't test it. Looks nice, though. Inspires confidence.

MrCreosote commented 3 years ago

The current version in kbase.yml is 0.1.30 and that has never been deployed to prod, so I think this change can just be wrapped into the same version.