re: goog.provide/require. The problem is that when plovr generates the test file, it uses script inclusion, which means the deps don't load until after the first script is done loading. So,
goog.require('goog.Component');
var Component = goog.Component;
would not work as expected. The options I considered were:
if the user added a goog.provide to their test file, use goog.require. otherwise, use script inclusion.
auto-generate a goog.provide for every test file, generate a deps-with-test-files.js, and always use goog.require
this solution (carry around the requires)
I went with this approach because there's less magic and it's easier to see what's going on.
re: "approve with comments": i think there is a way to make some changes then accept, but it involves some github-fu
added the escapeJsString
re: goog.provide/require. The problem is that when plovr generates the test file, it uses script inclusion, which means the deps don't load until after the first script is done loading. So,
would not work as expected. The options I considered were:
I went with this approach because there's less magic and it's easier to see what's going on.
re: "approve with comments": i think there is a way to make some changes then accept, but it involves some github-fu