search

bolinfest / plovr

plovr: a Closure build tool
78 stars 49 forks source link

Pass the parsed compiler options into the extract command #132

Closed theRobinator closed 7 years ago

theRobinator commented 7 years ago

This fixes a couple inconsistency issues, particularly https://github.com/bolinfest/plovr/issues/131.

I had to make the compiler argument to Config.getCompilerOptions nullable for this, since the compiler used here is private to the extractor.

I think the ideal solution here would involve modifying that file in the compiler itself to allow an optional compiler instance to be passed in, but I'm not sure about the interop between the two repos so I'm sticking to modifying just plovr for now.

nicks commented 7 years ago

cool, thanks for the fix! you're right that it's kind of gummy that getCompilerOptions is nullable now, but i have some ideas for how to fix that.