Closed rgpower closed 6 years ago
thanks for doing this! let me poke around at it a bit
mostly looks good. a few minor issues:
ok, i merged this in parts and made the auto-escaping changes. it was a bit messier than i would have liked but it worked out ok
Hey @nicks, thanks so very much for taking the time (and effort) to merge these updates. I am honoured to have been able to make even a small contribution to plovr, as it has been so beneficial to me and my colleagues.
Hey @nicks ,
I am hoping you will consider this pull request which updates plovr to use the latest closure-related jars from Maven central, in particular:
These updates required some small changes to plovr src in order to avoid use of removed/deprecated apis.
In particular:
closure-templates 2017-08-08 changes
closure-compiler v20171023 changes
other: