search

bolinfest / plovr

plovr: a Closure build tool
78 stars 48 forks source link

Update closure compiler v20181125 #167

Closed xvilo closed 4 years ago

xvilo commented 4 years ago
xvilo commented 4 years ago

Builds successfully here, could this be reviewed and merged?

nicks commented 4 years ago

thanks! but why only update to v20181125?

xvilo commented 4 years ago

There are currently more/other issues when updating to a higher version, currently working on it. But want to do it in smaller bits. A small update is better then no update right now.

there are some issues in the test suite regarding soy templates, so I have to tackle these before we can update to latest version

nicks commented 4 years ago

ok!

xvilo commented 4 years ago

@nicks can you also update the npm package? That would be highly appreciated: https://www.npmjs.com/package/plovr

nicks commented 4 years ago

will do! need to check out the repo and run some tests, and it's taking a bit.

xvilo commented 4 years ago

Great! Thanks for the swift responses, it's appreciated.

nicks commented 4 years ago

Ugh, unfortunately I'm travelling today and the wifi has been very unreliable. Trying to build + publish keeps failing. Will keep trying but may have to give up and try again tomorrow.

xvilo commented 4 years ago

Ah, I see it breaks now. I probably forgot to push one of the fixes to this repo. I had some trouble keeping everything separated between our internal repo and this one.

xvilo commented 4 years ago

@nicks, seems everything is in order with current master, here is a build: plovr-master-2019-10-5.jar

nicks commented 4 years ago

unfortunately, i no longer have access the the plovr npm package. it seems like Medium took it over :\