search

bolinfest / plovr

plovr: a Closure build tool
78 stars 49 forks source link

Bake compiler js resources into plovr jar #19

Closed nicks closed 10 years ago

nicks commented 10 years ago

i wish there was a better way to share the list of resources that needed to be copied.

bolinfest commented 10 years ago

What changed to suddenly make this necessary? On Apr 23, 2014 9:41 AM, "Nick Santos" notifications@github.com wrote:

i wish there was a better way to share the list of resources that needed

to be copied.

You can merge this Pull Request by running

git pull https://github.com/nicks/plovr nick-patch-build

Or view, comment on, or merge it at:

https://github.com/bolinfest/plovr/pull/19 Commit Summary

  • Bake compiler js resources into plovr jar

File Changes

  • M build.xmlhttps://github.com/bolinfest/plovr/pull/19/files#diff-0(6)

Patch Links:

— Reply to this email directly or view it on GitHubhttps://github.com/bolinfest/plovr/pull/19 .

nicks commented 10 years ago

The JS support code is only used for a few features (local vars in goog.scope, run-time type-checking), but it's likely we'll want to do other code-injection stuff the same way (e.g., the cross-module method motion support code)