Multi-column layout

[mykolaharmash]

"Goto Bookmark" window always sticks to first column of the layout, and if command was called not from first column window does not response to enter/escape key

[bollu]

I've done a rewrite of the plugin, please tell me if the issue persists ~Bollu

[mykolaharmash]

Yes, it's still there. To recreate issue, split layout on 2 columns and open different files in each. Add bookmark in first column, switch to second and try to goto first bookmark.

[bollu]

I haven't pushed the new update yet. It's on the rewrite branch :) Tell me in ~2 days

EDIT - Pushed new version. Tell me if it persists

[mykolaharmash]

Now I have an error

Traceback (most recent call last):
  File "/Applications/Sublime Text.app/Contents/MacOS/sublime_plugin.py", line 140, in create_window_commands
    cmds.append(class_(window))
  File "/Users/nikolay/Library/Application Support/Sublime Text 3/Packages/sublimeBookmark/sublimebookmark.py", line 205, in __init__
    self._Load()
  File "/Users/nikolay/Library/Application Support/Sublime Text 3/Packages/sublimeBookmark/sublimebookmark.py", line 474, in _Load
    BOOKMARKS = load(savefile)
ImportError: No module named 'SublimeBookmarks'

[mykolaharmash]

Maybe, I've done something wrong. I just cloned your repo with git clone -b rewrite https://github.com/bollu/sublimeBookmark.git to the "Packages" folder

[bollu]

Yeah you have to switch to the "st3" branch. I think the default branch is master.

Why not use package control to install? :)

[mykolaharmash]

Package Control installs package like a *.sublime-package zip by default, i have been lazy to extract it) Anyway, problem is still persists.

[bollu]

I'm sorry, but you must still be on an older branch.

try running this:

git remote update
git pull origin st3
git checkout st3

I'm sure you're running an older version since the line numbers are different in the newer version :)

[mykolaharmash]

No difference, still have a problem with 2 columns

[bollu]

I pushed a commit that should fix this - 6187996e365c5708c69f847f91895c1b4420430a Sorry it took so long. It's entirely my fault :)

Hope this fixes things. Thanks a lot for sticking with the bug :D

~bollu

[mykolaharmash]

Thanks, now it works) One more feature request. Can you add option to display bookmarks for current file only please?

[bollu]

Sure thing :) will do.

[bollu]

Done. added a new mode. Tell me if it works!

[mykolaharmash]

Thanks, it works. But there are some bugs. When bookmarks was added on both columns, and I try go to one of them, tabs start to jump randomly. It's hard to describe, try to reproduce please

[bollu]

That's on purpose - sublime text has some weird bugs in it that forces me to move the views around when you browse bookmarks. However, the views should go back to their original positions once you finish using the plugin.

Please tell me if the plugins regain their original positions once you're done using the plugin.

[mykolaharmash]

Sometimes it regains, but sometimes no

[bollu]

Ah, that is troubling in that case. sigh, wish I was better at python! Will work on this.

EDIT - I think I got what the bug was. I wasn't updating the groups info every time you ran goto / remove. I was running it every time you modified a file. Pushed a fix. tell me if it works!

[mykolaharmash]

Yes, now it works great, thank you!)

[bollu]

Cool. Closing this then :)