search

bolshakov / stoplight

:traffic_light: Traffic control for code.
http://bolshakov.github.io/stoplight/
MIT License
384 stars 40 forks source link

Add timeout option #108

Closed GabrielMalakias closed 8 years ago

GabrielMalakias commented 8 years ago

I like this gem and trying to use in some projects! Good work community :)

Some days ago, i've found a interesting property in Hystrix: "execution.isolation.thread.timeoutInMilliseconds

This property sets the time in milliseconds after which the caller will observe a timeout and walk away from the command execution."

I now, this gem isn't Hystrix, but adding timeout limit can you avoid latency (in some cases) and cascading failures.

I suggest this code, but it's only an opinion of a paltry dev :)

Thanks for all.

tfausak commented 8 years ago

I'm glad you like this gem, and thanks for opening this pull request!

Stoplight doesn't have timeouts because, as you've shown, they're very easy to add. I would rather keep Stoplight focused on doing one thing well. If you want something a little closer to Hystrix, I suggest checking out CircuitBox.

GabrielMalakias commented 8 years ago

Thanks Taylor. :)