Fix issuing notifications for a single light change

bolshakov / stoplight

:traffic_light: Traffic control for code.

http://bolshakov.github.io/stoplight/

MIT License

384 stars 40 forks source link

Fix issuing notifications for a single light change #125

Closed tony-rowan closed 4 years ago

tony-rowan commented 5 years ago

Previously, if a light changed to red before a request that failed returned, it would also 'set' the light to red and trigger another notification. This fixes this by only triggering the notification if the light was still green before handling the error.

tony-rowan commented 5 years ago

Fixes https://github.com/orgsync/stoplight/issues/116

tfausak commented 5 years ago

Thanks for opening this pull request! Unfortunately this repository is not maintained. If you're interested in becoming the maintainer, let me know. Otherwise I recommend you use your fork.

bolshakov commented 5 years ago

@rawstacktech would you mind adding a test case for this condition? Alternatively, you may allow edits from maintainers, and I'll try to add a test by myself.