search

bolshakov / stoplight

:traffic_light: Traffic control for code.
http://bolshakov.github.io/stoplight/
MIT License
384 stars 40 forks source link

Notifications should be sent asynchronously #31

Closed tfausak closed 10 years ago

tfausak commented 10 years ago

Sending notifications can take a while. Best case, HipChat takes about a quarter of a second. The first message, though, can take several seconds because it has to initialize a connection to HipChat.

tfausak commented 10 years ago

This can't really be done without involving a message queue like Resque. I think it's a cost we're just going to have to deal with. It should only happen once per stoplight anyway (when transitioning from green to red).

clifton commented 10 years ago

I agree. We should just keep it synchronous for now