search

bolshoytoster / hashlips_art_engine

HashLips Art Engine is a tool used to create multiple different instances of artworks based on provided layers.
MIT License
42 stars 34 forks source link

startEditionFrom: not working #3

Closed kingchenc closed 2 years ago

kingchenc commented 2 years ago

Checklist

Description

Hi,

startEditionFrom: 0 does not work.

const layerConfigurations = [
  {
    growEditionSizeTo: 250,
    startEditionFrom: 0,
    layersOrder: [
      { name: "Background" },
      { name: "Eyeball" },
      { name: "Eye color" },
      { name: "Iris" },
      { name: "Shine" },
      { name: "Bottom lid" },
      { name: "Top lid" },
    ],
  },
];

Example Conf with startEditionFrom 0, but it starts at 1.png

how to solve this?

thank you

Steps to reproduce

No response

Expected result

No response

Actual result

No response

Environment

OS Version (uname -a on unix, systeminfo on windows): Node.js version (node -v):

bolshoytoster commented 2 years ago

@kingchenc I've fixed it now, you can do it yourself by changing src/main.js ~line 440: https://github.com/bolshoytoster/hashlips_art_engine/blob/733520e66a115c78447c7297173ac08c3ed864b5/src/main.js#L439-L441

to

    if (network != NETWORK.sol && layerconfiguration.startEditionFrom != undefined) {
kingchenc commented 2 years ago

@bolshoytoster Thanks for the reply, i changed the following Code, but still starts at 1 :/

bolshoytoster commented 2 years ago

@kingchenc did you definetely save the src/main.js file?

kingchenc commented 2 years ago

@bolshoytoster Yes i saved it ;)

Created new one, still same output.

Created edition: 250, with DNA: 8ca27521450312a4888795948c7a23c1698d34db Saved edition: 2 Saved edition: 1 Saved edition: 4

bolshoytoster commented 2 years ago

@kingchenc it works for me, could you download the latest version of the repo.

kingchenc commented 2 years ago

@bolshoytoster Looks very strange... Downloaded your latest Repo with the StartEditionFrom Fix,

Added this to the config: (and yes i saved)

const layerConfigurations = [
  {
    growEditionSizeTo: 5,
    StartEditionFrom: 0,

But still the same output

Created edition: 1, with DNA: 62d9e30798ab3cbe6a6366f26ac17e68cc322cc1 Created edition: 2, with DNA: 92d6f5150aead5820b188bc56464b5e1961b160b Created edition: 3, with DNA: 594219bfa83c650c4811a0db3ad0c2ec03f5bdf2 Created edition: 4, with DNA: 9bb9813d780bc66544bbd1552711b069b03ebacd Created edition: 5, with DNA: ab40c455bf9dec78b50909d414d873442f5dd4f7 Saved edition: 1 Saved edition: 2 Saved edition: 3 Saved edition: 4 Saved edition: 5

bolshoytoster commented 2 years ago

@kingchenc I just realised your StartEditionFrom should start with a lowercase s.

kingchenc commented 2 years ago

@kingchenc I just realised your StartEditionFrom should start with a lowercase s.

Thanks that was it, seems simple.... Thank you <3