search

bolt / core

🧿 Bolt 5 core
https://boltcms.io
MIT License
550 stars 161 forks source link

Handle incorrect parameters gracefully #3510

Closed bobvandevijver closed 11 months ago

bobvandevijver commented 11 months ago

Solves a Warning: Undefined array key 1 notice.

Some clients do not understand how to use UTF-8, and execute a request to for example /thumbs/400%C3%83%C2%97400%C3%83%C2%97contain/news, which contains × instead of the expected ×. I do not know why %83%C2 is inserted in the URL (it is some sort of Python based external scanner...), but I do believe this code should be robust enough to not throw a warning when this happens. With this change the raw parameters are checked for existence before being used, allowing for a sane fallback.

I do not believe the CI failures are related to this change.

bobdenotter commented 11 months ago

Neat, thanks! 👍

I do not believe the CI failures are related to this change.

No, they aren't. I just haven't been able to make time to fix those. :-/