bolt / project

🚀 Repo to `composer create project` a Bolt 5 project.
MIT License
39 stars 38 forks source link

Feat: add new docker for production & development environment #31

Closed toofff closed 3 years ago

toofff commented 3 years ago

I added a CI for the installation of a Bolt project with Composer or Docker Compose.

The continuous integration is not yet working on this pull request because nothing is merged into the Bolt repository yet in my opinion. On the other hand you can see it working on my pull request in my fork

toofff commented 3 years ago

I'm glad you welcome this work like this. I still have some work to do but you can already test it with a simple docker-compose up. Everything is functional at home.

If you have more proposals, I am interested ;)

toofff commented 3 years ago

@bobdenotter

Little question, do you know why we had a "node" container in the docker?

Great news, I think I finished it all this week. Don't hesitate to test and give feedback ;)

bobdenotter commented 3 years ago

Little question, do you know why we had a "node" container in the docker?

No, i'm afraid I don't.. I don't really use Docker myself.

Perhaps @JarJak (🛎️) knows?

toofff commented 3 years ago

@bobdenotter I still have the documentation to finish, I hope to deliver it to you this week for the review :smile:

bobdenotter commented 3 years ago

@toofff Excellent! Looking forward to it!

toofff commented 3 years ago

@bobdenotter Now I pass the torch to you for proofreading and testing locally. I remain at your disposal for any questions and changes to be made. :)

bobdenotter commented 3 years ago

@toofff Thanks!

It'll take me a little while to review, because I'd like to do it with care. Will let you know if any questions arise.

simongroenewolt commented 3 years ago

Little question, do you know why we had a "node" container in the docker?

I don't know if you still have this question, but I think the node container is to build/process the javascript for the (vue based) editor support in /bolt

toofff commented 3 years ago

Thanks @simongroenewolt I'm watching this this week.

toofff commented 3 years ago

@simongroenewolt @bobdenotter

For me the container node is not necessary here. From what I could understand, this container is only needed for "bolt/assets" development. So not necessary for end developers who will develop websites with "bolt/project"

toofff commented 3 years ago

@bobdenotter did you have time to test with and without docker?

bobdenotter commented 3 years ago

@toofff Is this 'good to go' for now? If so, we'll merge it in shortly, and we fine-tune it before release of a new version of this repo.

toofff commented 3 years ago

I try to finalize tomorrow and do my rebase so that it is mergeable

toofff commented 3 years ago

@bobdenotter It's good for me, I made the last corrections of the CI, the rebase of the master branch, the update of composer 2.

You can test by following the README.md file and merge if you like.

If you want to view the CI, it is available on my fork