Closed toofff closed 3 years ago
Yes I deleted the .gitignore
file in the public folder. I prefer to have the project rules at the root but above all it forces you to have server rules so that this file is not accessible in production if it is forgotten during deployment.
Yes I deleted the .env.dist
file in the root project. Here are the new specs on this file since Symfony / flex
and Symfony 5
For PHP 7.4 it is a proposal, I can downgrade if you wish? Even though I personally prefer to be on the last minor version of the 7.x branch for creating a new project.
I'm glad you welcome this work like this. I still have some work to do but you can already test it with a simple docker-compose up
. Everything is functional at home.
If you have more proposals, I am interested ;)
@bobdenotter
Little question, do you know why we had a "node" container in the docker?
Great news, I think I finished it all this week. Don't hesitate to test and give feedback ;)
Little question, do you know why we had a "node" container in the docker?
No, i'm afraid I don't.. I don't really use Docker myself.
Perhaps @JarJak (🛎️) knows?
@bobdenotter I still have the documentation to finish, I hope to deliver it to you this week for the review :smile:
@toofff Excellent! Looking forward to it!
@bobdenotter Now I pass the torch to you for proofreading and testing locally. I remain at your disposal for any questions and changes to be made. :)
@toofff Thanks!
It'll take me a little while to review, because I'd like to do it with care. Will let you know if any questions arise.
Little question, do you know why we had a "node" container in the docker?
I don't know if you still have this question, but I think the node container is to build/process the javascript for the (vue based) editor support in /bolt
Thanks @simongroenewolt I'm watching this this week.
@simongroenewolt @bobdenotter
For me the container node is not necessary here. From what I could understand, this container is only needed for "bolt/assets" development. So not necessary for end developers who will develop websites with "bolt/project"
@bobdenotter did you have time to test with and without docker?
@toofff Is this 'good to go' for now? If so, we'll merge it in shortly, and we fine-tune it before release of a new version of this repo.
I try to finalize tomorrow and do my rebase so that it is mergeable
@bobdenotter It's good for me, I made the last corrections of the CI, the rebase of the master branch, the update of composer 2.
You can test by following the README.md
file and merge if you like.
If you want to view the CI, it is available on my fork
docker-compose.yml
&Dockerfile
layer divisionsphp
& configuration (env PROD & DEV)public/files
,public/theme
,public/thumbs
,var/cache
,var/log
&var/sessions
)php bin/console bolt:info
instead of launching after installing vendors (because it is looking for the version of the database which might not be launched in time)nginx
& configuration (env PROD & DEV)db
with MySQL 5.7 version (only env DEV)h2-proxy
to have SSL (only env DEV)mailcatcher
to do (only env DEV).dockerignore
file.editorconfig
file.env.dist
by.env
file, to respect symfony's good practice.gitignore
fileMakefile
fileREADME.md
filecomposer.json
file & update dependenciesbolt/core
4.0.1bolt/themes
3.3.2symfony.lock
file%kernel.project_dir%/src/Entity
for the use of our own entity)I added a CI for the installation of a Bolt project with Composer or Docker Compose.
The continuous integration is not yet working on this pull request because nothing is merged into the Bolt repository yet in my opinion. On the other hand you can see it working on my pull request in my fork