bolt / project

🚀 Repo to `composer create project` a Bolt 5 project.
MIT License
39 stars 38 forks source link

Feat: add CI with github action #40

Closed toofff closed 3 years ago

toofff commented 3 years ago

While waiting for the PR #31 to be merged I added a CI for the installation of a Bolt project

The continuous integration is not yet working on this pull request because nothing is merged into the Bolt repository yet in my opinion. On the other hand you can see it working on my pull request in my fork

bobdenotter commented 3 years ago

Hi @toofff Is this written on top of your other PR? As in: Does the other PR need to be merged first, in order for this PR tobe merged..

Just asking, because I noticed the 69 changed files ;-)

toofff commented 3 years ago

@bobdenotter it was in order not to pollute the other pull request that I made a second one because it is already big enough like that.

Yes to merge this one will have to wait until the other is merged

toofff commented 3 years ago

@bobdenotter I just finished adding the CI, you will be able to see the result in my fork.

So we could add cache on the docker images but we would have to add a registry on your side. We can see that later ;)

bobdenotter commented 3 years ago

Hey @toofff ,

I've discussed this, and i think the best course of action is that we'll merge in both of your PR's, and do a short round of beta testing on it. That way we'll be able to iron out the kinks as we go! :-)

The other day it came up that we needed some CI for this repo as well, after my goof with this commit: https://github.com/bolt/project/commit/acd6b72b789b919f87e996244eddbcd3667a435c 🤦

toofff commented 3 years ago

Ok, that's fine with me and I have some changes to make on my other pull request that will please everyone. I'm trying to do this to you tomorrow see Friday

toofff commented 3 years ago

Add this commit in #31