search

bolt / thumbs

Thumbnail handler for Bolt Images
12 stars 16 forks source link

Check if session is started before accessing #35

Closed GwendolenLynch closed 7 years ago

CarsonF commented 7 years ago

That voids the check completely.

GwendolenLynch commented 7 years ago

Yeah, hold this.

GwendolenLynch commented 7 years ago

@CarsonF I have :monkey: tested this and it seems to work as expected, i.e. if a session cookie is present in the initial request, the session will be restarted so this check is actually valid.

I have updated the tests as such, and covered off the deprecated use of $this->getMock() in the process.

CarsonF commented 7 years ago

Ah! Because session listener starts the session if precious exists.

CarsonF commented 7 years ago

Can you remove the isset around session check? It's very non intuitive IMO

GwendolenLynch commented 7 years ago

Can you remove the isset around session check? It's very non intuitive IMO

Ha! I can't believe I missed that … Done!