search

bolt / thumbs

Thumbnail handler for Bolt Images
12 stars 16 forks source link

Handle an invalid resource and return an empty GD resource #45

Closed GwendolenLynch closed 7 years ago

GwendolenLynch commented 7 years ago

As referenced https://github.com/bolt/filesystem/pull/52#issuecomment-302430549

Closes https://github.com/bolt/bolt/issues/6677

GwendolenLynch commented 7 years ago

I would rather throw an exception here, similar to createFromFile.

OK, that is me misunderstanding this:

We should make sure thumbs handles the invalid object correctly instead of relying on an exception to be thrown.

… as you not wanting to throw them here for the same reason … what a relief! Throwing the exception :+1: :smile:

I should be back online early-ish in your day time there, we'll sort the FS stuff and tag, then revisit this from there.

GwendolenLynch commented 7 years ago

OK, done and done.