boltdesignsystem / bolt

The Bolt Design System provides robust Twig and Web Component-powered UI components, reusable visual styles, and powerful tooling to help developers, designers, and content authors build, maintain, and scale best of class digital experiences.
https://boltdesignsystem.com
MIT License
292 stars 45 forks source link

[DO NOT MERGE] DS-744 refine theme colors for table #2472

Closed MarcinMr closed 2 years ago

MarcinMr commented 2 years ago

Jira

https://pegadigitalit.atlassian.net/browse/DS-744

Summary

Colors were updated for the table body and headers.

Details

How to test

MarcinMr commented 2 years ago

@mikemai2awesome

I updated the table colors so you can check what it looks like. I think for the table better work with shadow colors rather created one gray color for dark mode and one gray color for light mode. BTW I had to create examples of shadow colors for some colors like Pink, Berry, Wine, Violet, Yellow, and Orange. I wonder why we didn't have these shadows before?

First I tried with the tertiary color for table headers but first of all, this didn't pass the contrast test for some of the colors and secondly, we can't use transparent colors since we have sticky headers in the table and when headers are moving they are transparent causing that body content was visible thru sticky headers during scrolling.

When it comes to table borders I believe these should be more visible and have good contrast color as these are for separating tabular data and not for decorative purposes. So I used var(--m-bolt-neutral) color for borders. Previously, the gray border color wasn't well contrasted with some of the dark color themes.

Moreover, FYI I'm not sure if using var(--m-bolt-tertiary) for some colors like for example teal or orange on the tertiary buttons are good. You can check here https://boltdesignsystem.com/pattern-lab/?p=visual-styles-theming-system scroll down to the buttons section and see that the text on teal color and orange color, tertiary butons are not well contrasted (below 3) in relation to color contrast a11y test for both large and small text.