search

boltdesignsystem / bolt

The Bolt Design System provides robust Twig and Web Component-powered UI components, reusable visual styles, and powerful tooling to help developers, designers, and content authors build, maintain, and scale best of class digital experiences.
https://boltdesignsystem.com
MIT License
292 stars 45 forks source link

DS-796 Remove Ratio Object #2501

Closed MarcinMr closed 2 years ago

MarcinMr commented 2 years ago

Jira

https://pegadigitalit.atlassian.net/browse/DS-796

Summary

Ratio object is removed from the global > styles > 05-objects folder.

Details

Referring to the previously research ticket we don't need the ratio object anymore.

How to test

Pull the branch. Check if there's no ratio object in the Bolt repository and usage of that.

Release notes

The ratio object is no longer in use. We have the old ratio-component and the new ratio-element.

colbytcook commented 2 years ago

@remydenton Adding you to this PR for review. Currently there is a couple places where this object is being used on the Drupal side so I wanted to make sure we shouldn't have this be merged into 6.0 instead of master since it could be a breaking change?

remydenton commented 2 years ago

Thanks @colbytcook. It looks like the places it's still in use in Drupal are all non-functional (a hack for the hapyak player which hasn't been used in years and a file for search summary which was only ever used for demos, and is not a good example anyway).

That said, I think for consistency and to not be jerks by knowingly removing things that once worked without telling anyone, we should merge this into 6.0 instead.

remydenton commented 2 years ago

I tried updating the base branch, but even after merging the latest master into release/6.x, this PR is showing a lot of noise commits. @MarcinMr, would you be able to look into that (maybe rebase this PR if necessary)?

colbytcook commented 2 years ago

@MarcinMr to keep our workflow consistent we are going to merge this PR in the release/6.x branch, unfortunately when we updated this on the PR something went wrong. Could we just recreate this PR based off the release/6.x branch? I figure since it was a pretty small PR it would be easier just doing that instead of trying to figure out what is going on with this PR. Just make sure you add a link to this PR just so we can track the conversation.

MarcinMr commented 2 years ago

The new PR: https://github.com/boltdesignsystem/bolt/pull/2506