search

bolteu / screenshotty

A library for programatically capturing screenshots on Android
MIT License
265 stars 41 forks source link

PixelCopy BMP sizes are wrong #11

Closed norbert-sziraczki closed 4 years ago

norbert-sziraczki commented 4 years ago

The ScreenShotSpec taken from the window now uses the getSize method, that removes the soft buttons from the size, however the screenshot contains the part where it should be (in black) and the status bar as well. This makes the aspect ratio wrong. You should use getRealSize instead.

xzaleksey commented 4 years ago

Thank you. We will check and make a fix for this one.

MirzaAhmedBaig commented 4 years ago

is that done?

yarolegovich commented 4 years ago

Yes, the fix is in 1.0.3

andy-weinstein commented 3 years ago

I have an aspect-ratio issue on the Pixel 5 running Android 11, using version 1.0.3 of the library It is stretched a bit vertically, seemingly including the top status area in the size that it writes the image into. I can't comment on the API's getSize or getRealSize - I don't have much experience there. No issue on Samsung A7 or LG Nexus 5