Alt-N, goto-next-clone, does not select proper body text

[edreamleo]

This is a serious bug that might lead to corrupted data.

Using LeoJS in vscode.dev:

• Open Leo's github repo: https://github.com/leo-editor/leo-editor
• Open LeoPyRef.leo in LeoJS.
• Clone a node containing text. I cloned class NestedSplitterTopLevel (QWidget)
• Move the clone so it is the last top-level node.
• Alt-N selects the original (now cloned) node but does not select the proper body text!

It appears that the body text is the text of the node's parent.

[boltex]

@edreamleo Hmm, I cannot reproduce this bug. I did it with LeoPyRef exactly like you suggested... weird.

Perhaps you could grab screenshot, or setup a zoom session if you can reproduce the bug reliably?

[edreamleo]

On Mon, Dec 11, 2023 at 7:18 PM Felix @.***> wrote:

Perhaps you could grab screenshot, or setup a zoom session if you can reproduce the bug reliably?

I definitely can reproduce this both with desktop vs-code and vscode.dev on Microsoft Edge.

In both cases, I have enabled LeoJS and disabled LeoInteg. To reproduce:

• Create a clone of a node containing text. It should not be a top-level node.
• Move the clone so it is the last top-level node.
• Alt-N.

The problem doesn't always happen, but it usually does. Screenshot below. The outline pane highlights the node BaseText.make_data, but the body pane contains the text of the top-level "Code" node.

BTW, the tab name 'LEOJS: BODY' is useless. It would be much better to have it display c.p.h.

I would be happy to zoom about this.

Edward

[image: image.png]

[edreamleo]

I definitely can reproduce this both with desktop vs-code and vscode.dev on Microsoft Edge.

In both cases, I have enabled LeoJS and disabled LeoInteg.

I just re-enabled LeoInteg. I get the same failure with desktop vs-code.

Edward

[boltex]

@edreamleo Thanks for showing me a reproduction of the bud. I've just noticed also that Leo actually allows you to do this command on a non-clone node, in which case it just does a 'find next clone'.

I'll start by fixing this behavior to match Leo and go on from this to make more experiments to try to squash this bug.

[edreamleo]

On Sat, Dec 16, 2023 at 1:25 PM Felix @.***> wrote:

@edreamleo https://github.com/edreamleo Thanks for showing me a reproduction of the bud. I've just noticed also that Leo actually allows you to do this command on a non-clone node, in which case it just does a 'find next clone'.

You're welcome.

I'll start by fixing this behavior to match Leo and go on from this to make more experiments to try to squash this bug.

Happy hunting :-)

Edward

[boltex]

@edreamleo the devel branch now has a possible fix. Can you try it out on your machine ? (I'll send you a pre-packaged extension file if you prefer)

[boltex]

@edreamleo I just found a way to reproduce it reliably on my machine: the other (target) clone to be navigated-to has to be hidden in a collapsed part of the tree.

The goto-next-marked command has the same problem. I'm near finding the exact source of the problem for those command refresh-ui resolution bugs.

[edreamleo]

@boltex I've pulled devel. How do I test the code?

[boltex]

Just by launching the debugger with F5. But no need to do so now because I've found a way to reproduce! So dont bother since I can now test reliably by myself. (I proposed that you tried it out because i could not reproduce the bug earlier.. hehe.)

[edreamleo]

@boltex Alright. I'll leave you to it. Good luck!

[boltex]

Fixed in #70 Now live as version 0.2.4 :partying_face:

[edreamleo]

@boltex The fix works for me on both vs-code and vscode.dev.