search

boltjs / bolt

Bolt. A javascript module system.
http://boltjs.io
Other
11 stars 0 forks source link

Sublime plugin doesn't work with Sublime Text 3 #44

Open marlimox opened 10 years ago

marlimox commented 10 years ago

It appears to install on ST3 but the menu says "Bolt (open)" and all the menu items are greyed out.

On the pull request for submitting the plugin to the package control channel, one of the devs mentioned the following:

"since you are using absolute imports in main.py I highly doubt that this package works with ST3. If that's indeed the case, please specify an ST version selector string."

I don't know how helpful that is, my Python skills are rusty. I tried reading up on absolute imports in Python and my understanding is that, in general, you should be using them in preference over relative imports, so I don't know what the guy was talking about.

But in any case, our plugin should be updated to work with ST3.

In the meantime, I've changed our Sublime version string in the channel json be "<3000", so it won't install on Sublime Text 3 or later.

FYI there is a porting guide here too: http://www.sublimetext.com/docs/3/porting_guide.html.

disquieting-silence commented 10 years ago

That version only works with v2. Some people use 3 at work, so we've had to get it to work there, but not on that repo yet. It's not particularly hard, but I'm not going to get around to doing it in the next week. There are package declaration changes, edit object refactoring in text commands, sorting changes, string encoding and maybe a few other things. As it stands, it definitely only works in v2. Sorry. On Sep 3, 2013 9:13 AM, "Marli Oshlack" notifications@github.com wrote:

It appears to install on ST3 but the menu says "Bolt (open)" and all the menu items are greyed out.

On the pull request for submitting the plugin to the package control channel, one of the devs mentioned the following:

"since you are using absolute imports in main.py I highly doubt that this package works with ST3. If that's indeed the case, please specify an ST version selector string."

I don't know how helpful that is, my Python skills are rusty. I tried reading up on absolute imports in Python and my understanding is that, in general, you should be using them in preference over relative imports, so I don't know what the guy was talking about.

But in any case, our plugin should be updated to work with ST3.

In the meantime, I've changed our Sublime version string in the channel json be "<3000", so it won't install on Sublime Text 3 or later.

FYI there is a porting guide here too: http://www.sublimetext.com/docs/3/porting_guide.html.

— Reply to this email directly or view it on GitHubhttps://github.com/boltjs/bolt/issues/44 .

marlimox commented 10 years ago

That's fine. I would be happy to check the changes in for you and get it to work if you just send me a dump of the latest code. If you've got it to work on 3, it should just work if I check it in and produce a build right?

marlimox commented 10 years ago

Or you mean you haven't got it to work on top of additional changes that have been in the boltjs/bolt repo that you don't have internally?