search

boltlabs-inc / tezos-contract

Multi-sig Smart Contract for zkChannels protocol
MIT License
3 stars 1 forks source link

Have more specific close statuses #43

Closed DariusParvin closed 3 years ago

DariusParvin commented 3 years ago

@marsella pointed out that right now if you look at a contract with status CLOSED, you cannot tell which close flow it took without referencing anything else.

It seems like it would be useful to have more specific close statuses to differentiate the different close flows. Note that it wouldn't affect the gas or storage costs.

DariusParvin commented 3 years ago

thoughts @indomitableSwan @jakinyele?

indomitableSwan commented 3 years ago

I believe we already settled this on slack in the affirmative.

DariusParvin commented 3 years ago

After talking just now, I'll wait until @marsella or @indomitableSwan confirm we want this.

indomitableSwan commented 3 years ago

@marsella Thoughts?

marsella commented 3 years ago

These should no longer be necessary. I believe the polling service and general zeekoe architecture work without these statuses; we extra zeekoe statuses to indicate which close flow we're in, instead of using PendingClose for everything.

We can still add them if we want to be able to examine a contract and determine what happened after the fact. For example, a party looking through their closed channels cannot determine how they were closed right now. We could solve that by adding more close statuses on either the zeekoe or the contract end. But it is not necessary for a functional protocol.

indomitableSwan commented 3 years ago

@jakinyele Given the above, are we safe to close this issue?

jakinyele commented 3 years ago

@indomitableSwan I think so