search

boltlabs-inc / tezos-contract

Multi-sig Smart Contract for zkChannels protocol
MIT License
3 stars 1 forks source link

add CI to run build script #60

Closed marsella closed 3 years ago

marsella commented 3 years ago

This PR adds a build script to make sure that the zkchannels_contract.json file matches the one generated by building the current contract version. This will avoid a mistake where we update the contract but forget to update the JSON file in the repo, and users can't tell which is correct.

This addresses an concern raised in boltlabs-inc/zeekoe#229

DariusParvin commented 3 years ago

looks good to me (although I'm not so familiar with build scripts).

build-contract.sh also generates a .tz file of the contract and currently we have that version in the repo too. Either we should get rid of the .tz file, or we should also check in this PR that the .tz file is correct too. It has the same file name as the json, just .tz instead of .json.

We don't use the .tz file for anything but it might still be useful for reviewers/debugging? @jakinyele

marsella commented 3 years ago

Good call, I just added a check for the tz file.

marsella commented 3 years ago

I was worried that the diff would fail silently if the files are different, but that appears to not be the case, per #61.